Handle bool primitive types#54
Merged
alexcrocha merged 1 commit intoar-rust-rbs-buildfrom Oct 30, 2025
Merged
Conversation
This was referenced Oct 29, 2025
Merged
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
changed the title
st0012
approved these changes
Oct 29, 2025
alexcrocha
deleted the
Add_bool_field_type_support_to_Rust_RBS_bindings
branch
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
Since `bool` is a primitive type with direct FFI mapping between C and Rust, we don't need a wrapper struct like we do for complex types (`rbs_string_t`, etc.).
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
Since `bool` is a primitive type with direct FFI mapping between C and Rust, we don't need a wrapper struct like we do for complex types (`rbs_string_t`, etc.).
alexcrocha
added a commit
that referenced
this pull request
Jan 14, 2026
Since `bool` is a primitive type with direct FFI mapping between C and Rust, we don't need a wrapper struct like we do for complex types (`rbs_string_t`, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
build.rsto properly generate fields and accessors forboolc_types fromconfig.yml, allowing nodes likeBoolNodeto correctly generate withvalue: boolfields.Since
boolis a primitive type with direct FFI mapping between C and Rust, we don't need a wrapper struct like we do for complex types (rbs_string_t, etc.).